feat/release-page #1
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/release-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The github context was kept for compatibility in yavsc's .forgejo/workflows/release.yml, but we don't need that here — the forgejo context is canonical and we want zero GitHub-flavoured naming in this script. - All ${{ github.* }} -> ${{ forgejo.* }} - Env vars GITHUB_API_URL / GITHUB_REPOSITORY / GITHUB_TOKEN -> FORGEJO_API_URL / FORGEJO_REPOSITORY / FORGEJO_TOKEN - The token's source (${{ secrets.GITHUB_TOKEN }}) is the one exception: that's the runtime variable name exposed by the upstream Action runner, not a naming choice. A comment in the env block explains why we read it under the legacy name and immediately re-bind it to FORGEJO_TOKEN. - Same for $GITHUB_ENV (inter-step env file): runtime-controlled name, kept under its technical identity with a note. YAML re-validated with yaml.safe_load.Following up on the previous commit (forgejo.* / FORGEJO_TOKEN env vars): the previous version still had two carve-outs that kept github-flavoured names alive in this script, namely - ${{ secrets.GITHUB_TOKEN }} (token source) -> ${{ forgejo.token }} - $GITHUB_ENV (inter-step state file) -> /tmp/release-state.env Both name choices were inherited from yavsc's workflow without re-checking. Neither is forced by Forgejo; the auto-provided token is exposed via the forgejo context, and inter-step state can be persisted via a plain env file sourced at the top of each step. Result: zero occurrences of 'github' (case-insensitive) anywhere in .forgejo/workflows/release.yml. YAML re-validated with yaml.safe_load.The previous commit switched to ${{ forgejo.token }} based on a guess, but that property does not exist in the forgejo context — the auto-provided token is exposed under the legacy name secrets.GITHUB_TOKEN (a holdover from the upstream Action runner codebase). This is documented empirically by yavsc/.forgejo/workflows/release.yml, which uses this same expression and works. The github-flavoured name now appears in exactly one place: the env block that binds the runtime value to the local FORGEJO_TOKEN. Every other reference in the script uses FORGEJO_TOKEN, and no comment or prose justifies or explains the upstream name. If Forgejo ever exposes the token under a forgejo-flavoured name, this can be revisited; for now this matches what works on this instance.