Commit graph

3,222 commits

Author SHA1 Message Date
04607aeaab fixes the tests 2026-08-25 23:01:00 +01:00
d78e3ab860 Do not fail at attaching developer tools 2026-08-25 21:15:04 +01:00
c16345674b Package renamed impact 2026-08-25 20:30:39 +01:00
d4f9822faa Release 1.0.8-rc3 - unstable 2026-08-25 19:49:12 +01:00
790faad27b Fixes the Android Login process 2026-08-25 19:20:03 +01:00
776fb10903 refacto Makefiles and MainView setup 2026-08-25 14:53:25 +01:00
a0f0fb1282 test are still ok! 2026-08-25 14:16:49 +01:00
6813fce8c9 simpler is better 2026-08-24 16:26:42 +01:00
3f3f5b5575 code format 2026-08-24 16:26:23 +01:00
a73135d4a1 It was too much for qemu 2026-08-24 16:25:45 +01:00
72c1dede61 restore the TextEditor 2026-08-24 01:43:47 +01:00
2977f74980 don't wait from App Nav push ok on loggin succeded 2026-08-24 01:23:15 +01:00
93604a9498 show the window 2026-08-24 00:30:29 +01:00
49d3c8da81 Simpler is better 2026-08-24 00:18:07 +01:00
b2a20d713c updated 2026-08-24 00:17:43 +01:00
d5c7419219 restores the legacy behavior 2026-08-24 00:03:14 +01:00
4926c2f27e changes 2026-08-23 23:30:37 +01:00
3206523365 Merge branch 'feat/ui-testing' into release/1.0.8-rc3 2026-08-23 23:26:59 +01:00
569ed6b304 chore(release): bump version via gitversion for 1.0.8-rc3 2026-08-23 23:19:48 +01:00
8d103b36d8 Merge pull request 'release/1.0.8-rc1' (#42) from release/1.0.8-rc1 into main
Reviewed-on: #42
2026-08-23 23:19:06 +01:00
fbedd882dd ignore the failling test
Some checks failed
Forgejo Release / release (push) Failing after 4s
2026-08-23 23:09:37 +01:00
6ccd298588 refacto static extension for Service provider 2026-08-23 23:07:40 +01:00
ae86bf51b0 test are green !?! 2026-08-23 21:28:26 +01:00
1037120522 LOGCAT_BOOT_WAIT ?= 30 2026-08-23 18:39:37 +01:00
4596206e3d more reliable 2026-08-23 18:34:34 +01:00
56247e3d17 Fixes the test suite 2026-08-22 18:31:30 +01:00
18b87d65df build(android): align with .NET 11 SDK + drop unused AndroidX refs
Follow-up to the a70d2f78 'sdk version bump' (net10.0 -> net11.0
across the whole solution) and the work to get PostIt.Android building
under the .NET 11 preview SDK installed locally (~/.dotnet):

- Drop Xamarin.AndroidX.Browser and Xamarin.AndroidX.Core.SplashScreen
  from PostIt/Directory.Packages.props. They are not pulled by
  Avalonia.Android 12.1.1 (its nuspec declares AppCompat + Window only),
  are not referenced by any PostIt code, and we already removed the
  SplashScreen XML attributes from styles.xml in commit 00c0cb7f.

- PostIt.Android.csproj: bump SupportedOSPlatformVersion 23.0.0 ->
  24.0.0. Required by the Microsoft.Android.Sdk.Linux 37.0.0-preview.7
  target (Android API 24 is the new minimum under .NET 11); below that
  the build emits NETSDK warnings about an EoL target SDK level.

Build status (PostIt.Android, Debug, android-x64, EmbedAssemblies):
  0 errors, 15 warnings, ~4m24s cold. The locally-installed .NET 11
  SDK 11.0.100-preview.7.26381.103 needs /opt/android-sdk/platforms
  /android-37.0 to exist; Paul has set up a symlink to the
  android-37.1 (Android 17 preview) install until Microsoft catches
  up the SDK manifest.

PostIt.Tests: 49/62 passing after the migration; 13 new failures,
most of them HttpListener teardown noise around the OIDC stub
authority suite. Out of scope of this commit.
2026-08-22 18:04:27 +01:00
a70d2f789e sdk version bump 2026-08-22 16:58:08 +01:00
fc2afffbeb Revert "build(android): downgrade Avalonia 12 -> 11.3.20 + Avalonia.Maui 11.3.0"
This reverts commit 03d0cc9f71.
2026-08-22 16:09:35 +01:00
03d0cc9f71 build(android): downgrade Avalonia 12 -> 11.3.20 + Avalonia.Maui 11.3.0
WIP: addressing the layer-3 WindowingPlatformStub.NotSupportedException
crash on PostIt.Android by downgrading to the Avalonia 11 / Avalonia.Maui
11 stack, where the Android runtime platform layer (IWindowingPlatform)
gets properly bound via the MAUI embedding extension instead of being
left as a stub.

Touched files:

- src/PostIt/Directory.Packages.props:
  - Avalonia 12.1.1 -> 11.3.20 (Avalonia, Avalonia.Android,
    Avalonia.AvaloniaEdit, Avalonia.Browser, Avalonia.Desktop,
    Avalonia.Fonts.Inter, Avalonia.Themes.Fluent).
  - New: Avalonia.Maui 11.3.0.
  - Microsoft.Maui.Essentials 10.0.100 -> 8.0.100 (aligns with the
    Microsoft.Maui.Controls 8.0.x family that Avalonia.Maui 11.3.0
    pulls transitively).
  - New: Microsoft.Maui.Controls 8.0.100.

- src/PostIt/PostIt.Android/PostIt.Android.csproj:
  - TargetFramework net10.0-android -> net9.0-android36.0 (Avalonia
    Android 11.3.20 targets net8.0-android34.0, but the
    compat-ascending fallback lets us consume from net9.0-android36.0
    against the API-36 platform that's already installed locally).
  - Add Avalonia.Maui PackageReference.
  - Restore Microsoft.Maui.Essentials PackageReference (left in
    earlier removal during the MAUI-cause-of-crash hypothesis check).

- src/PostIt/PostIt/PostIt.csproj: TargetFramework net10.0 -> net9.0
  (must match what PostIt.Android consumes transitively, otherwise
  the build chain breaks).

- src/Yavsc.Abstract/Yavsc.Abstract.csproj: net10.0 -> net9.0 (same
  reason; six other consumers stay on net10.0 and pick up the new
  assembly via standard TFM compat).

- src/Yavsc.Api.Client/Yavsc.Api.Client.csproj: net10.0 -> net9.0
  (same reason).

- src/PostIt/PostIt.Android/Application.cs: rewritten as a bare
  Android.App.Application. Avalonia 11 no longer ships
  AvaloniaAndroidApplication<TApp> (that was an Avalonia 12
  introduction); the Avalonia init now lives in MainActivity via
  AvaloniaMainActivity<TApp>. The class is kept only so the
  [Application] manifest entry remains.

- src/PostIt/PostIt.Android/MainActivity.cs: now inherits
  AvaloniaMainActivity<App> and overrides CustomizeAppBuilder to
  chain .UseMaui<PostIt.Maui.MauiEmbeddingApp>(this) before
  .WithInterFont(). AvaloniaMainActivity<TApp> handles the
  AvaloniaView initialisation in OnCreate.

- src/PostIt/PostIt/Maui/MauiEmbeddingApp.cs (new): empty
  Microsoft.Maui.Controls.Application used as the embedding host for
  Avalonia.Maui. The MAUI window it produces is consumed by the
  Avalonia.Maui embedding pipeline and never surfaces to the user;
  Avalonia owns the actual visual tree.

Build status: 11 errors remaining, all CS0234 / CS0246 against
'Avalonia.Controls.ContentPage'. Avalonia 11 did not ship
ContentPage (it's an Avalonia 12 type, presumably for MAUI parity).
All seven PostIt pages inherit ContentPage today and need to be
reworked to UserControl before the build can complete. Follow-up
commit will do that.

Reference: AGENTS.md, 'PostIt.Android boot crash sur AVD x86_64 :
investigation par couches', couche 3.
2026-08-22 15:56:52 +01:00
00c0cb7f0a build(android): drop unused Xamarin.AndroidX.SplashScreen resources
- PostIt.Android.csproj: drop Xamarin.AndroidX.Core.SplashScreen and
  Xamarin.AndroidX.Browser. Neither is pulled transitively by
  Avalonia.Android 12.1.1 (its nuspec declares only AppCompat +
  Window), and they are not referenced anywhere in PostIt code.
- Resources/values-v31/styles.xml: drop the windowSplashScreen*
  items and the 'postSplashScreenTheme' reference, which require
  the dropped SplashScreen package. We fall back to the system
  splash screen on Android 12+ devices; a custom one can come
  back when we add it on purpose.
2026-08-22 15:32:43 +01:00
d73f623157 code REORG, pour partage pkg version entre app et tests 2026-08-22 15:17:08 +01:00
cdb9f438ab app domain name 2026-08-22 14:18:03 +01:00
19a698d5ef chore(android): bump Avalonia to 12.1.1, raise logcat boot wait
Two adjustments after the Android boot investigation
(cf. AGENTS.md section 'PostIt.Android boot crash sur AVD
x86_64 : investigation par couches'):

- Avalonia 12.0.4 -> 12.1.1 in PostIt/Directory.Packages.props.
  12.1.x is the current Avalonia 12 stable line; 12.0.4 had a
  known WindowingPlatformStub regression on Pixel x86_64 AVDs
  (issue AvaloniaUI/Avalonia#18459 family). 12.1.1 does not
  actually fix the layer-3 NotSupportedException on this
  specific Pixel + Android 16 + x86_64 combination (verified
  by rebuild + logcat capture on 2026-08-22), but staying on
  12.0.4 forever is wrong, and 12.1.1 is the baseline most
  users are on. The Makefile qemu-build already passes
  -p:EmbedAssembliesIntoApk=true and -p:RuntimeIdentifier=
  android-x64 to work around the Fast Deployment / AOT issues.

- qemu-logcat-boot LOGCAT_BOOT_WAIT 15s -> 30s. The crash
  reproduces well under 5s, so the wait value is moot for
  diagnosis, but 30s gives a wider margin when the runtime
  happens to be slow to JIT (boot tries to draw a frame in
  texture-pass scenarios). Override on the command line is
  unchanged: 'make qemu-logcat-boot LOGCAT_BOOT_WAIT=N'.

No MAUI change: Microsoft.Maui.Essentials was deliberately
unhooked during a hypothesis check and put back to keep the
contact-flow code path stable. The MAUI removal made no
difference to the crash (verified).
2026-08-22 14:06:48 +01:00
efed10fbbf monodroid ne crashe plus, l'app se lance 2026-08-22 06:42:12 +01:00
c14ca66f63 build(make): fix qemu Android install with EmbedAssembliesIntoApk
The qemu install path used to crash on startup with
'No assemblies found in files/.__override__/<rid>':
monodroid-glue.cc:757 / SIGABRT. Root cause: the .NET 10 Android
SDK defaults to Fast Deployment in Debug, which ships the APK
without managed assemblies and pushes them at runtime via adb —
not viable on the qemu emulator.

Fix:
- Replace the no-op -p:AndroidEnableFastDeployment=false flag
  (does not exist as an MSBuild property in the .NET 10 SDK) with
  -p:EmbedAssembliesIntoApk=true, which forces the build to
  cross-compile the managed assemblies into native lib_*.dll.so
  libraries for every ABI and pack them into the APK under
  lib/<arch>/. The Mono runtime then loads them directly,
  bypassing the Fast Deployment code path entirely.
- Add CONFIG variable passthrough so 'make qemu-install CONFIG=Release'
  builds an optimised APK for release smoke tests.
- qemu-build now consumes $(CONFIG) instead of hardcoded 'Debug'
  for the APK output path.

Side effect: the Debug APK balloons from ~13 MB (libs only) to
~160 MB (libs + AOT-compiled assemblies for all four supported
ABIs). That is acceptable for the local qemu install path; the
Forgejo release workflow builds Release APKs separately and is
unaffected.

Validated end-to-end on this machine: AVD boots in 109s, the
build produces an APK with lib_*.dll.so for x86_64 (125 MB),
uninstall + reinstall + am start no longer aborts at
monodroid-glue.cc:757 (next test will confirm the app actually
renders, this commit only fixes the Fast Deployment crash).

Also adds qemu-logcat-boot target from the previous edit
(unchanged, documented in this commit message for context).
2026-08-22 05:47:31 +01:00
a392dfdf89 build(make): add qemu Android AVD install targets
Targets for building and installing PostIt.Android (Debug) on the
local postit_test_avd AVD without leaving the terminal:

  make qemu            # run AVD -> wait boot -> build APK -> install
  make qemu-install    # (re)build APK + install (AVD must be running)
  make qemu-build      # build APK alone (no install)
  make qemu-run        # start the AVD in the background
  make qemu-wait-boot  # block until sys.boot_completed=1 (180s timeout)
  make qemu-stop       # adb emu kill

Defaults match the local setup: AVD postit_test_avd on x86_64
(android-x64 RID), adb on emulator-5554, Android SDK at
/opt/android-sdk. All overridable on the command line:

  make qemu POSTIT_RID=android-arm64 ADB_SERIAL=emulator-5556

EMU_HEADLESS=1 disables the emulator window for scripted runs.
qemu-run logs to /tmp/yavsc-emu/<avd>.log.

Validated end-to-end on this machine: AVD booted in 109s on a
loaded system, APK built and installed cleanly. The 'UI not
responsive' warning is the software-rendering fallback when KVM
is busy; it does not block the install.
2026-08-22 05:01:29 +01:00
ca9e78fb6f test(org): isolate in-memory store per fixture
TestWebApplicationFactory instances shared the same in-memory database
because EF Core's UseInMemoryDatabase("InMemory") returns the same
backing store to every DbContext that asks for it under the same
connection string, in the same process. Whichever fixture started
first defined the state, and every subsequent fixture inherited it,
making tests silently order-dependent and flaky.

Fix:

- Yavsc.Tests.Shared/InMemoryDatabaseName: helper that suffixes the
  in-memory connection string with a per-fixture GUID.
- TestWebApplicationFactory: instance GUID + ConnectionStrings__
  YavscConnection set as an environment variable in the constructor
  and cleared in Dispose, so each factory gets its own backing store.
  Env var is needed because IdentityServer8.EntityFramework exposes
  ConfigureDbContext as Action<DbContextOptionsBuilder> with no
  service-provider access, so the connection string is captured at
  registration time. AddEnvironmentVariables is the last provider in
  the config pipeline and wins regardless.
- WebServerFixture: process-static GUID (WebHostFixture is a
  per-process singleton by design, so the test collection shares one
  store; the GUID still isolates from TestWebApplicationFactory).
- AddIdentityDBAndStores: read the connection string at DbContext
  construction time via the (sp, options) overload of AddDbContext,
  so test fixtures can override it via the host's IConfiguration.
  IdentityServer stores cannot do the same without subclassing the
  framework's DbContexts; the env var path is the documented escape
  hatch in HostingExtensions.AddIdentityServer.
- UsesInMemoryProvider: StartsWith instead of equality, so
  'InMemory-{guid}' is still recognised as an in-memory connection
  string.

Regression sentinel in
Controllers/TestWebApplicationFactoryIsolationTests: two factories
seed a marker client in the first, the second must not see it.

Suite: 45/45 over 3 stable runs, 13-15s each.
2026-08-22 04:36:52 +01:00
6fc266395e tests(org): forward CancellationToken to ReceiveEstimateSignatureAsync
xUnit1051 in two cases that call
EstimateSignatureFileHelper.ReceiveEstimateSignatureAsync through
Assert.ThrowsAsync lambdas. The lambda body runs on a different
stack frame, so capturing TestContext.Current.CancellationToken
in a local variable before the lambda is required — otherwise
xUnit1051 still flags the call (the implicit 'default' from
the parameter default lives in the lambda's scope, not the
test's).

The 2 xUnit1013 warnings on BaseTestContext.GitClone remain —
unrelated, about visibility vs [Fact] attribute on a helper
method, structural cleanup for another commit.
2026-08-22 03:46:06 +01:00
105284e5e4 tests(blogs): pass TestContext.Current.CancellationToken to HTTP calls
xUnit1051: HTTP helpers (GetAsync, PostAsJsonAsync, PutAsJsonAsync,
DeleteAsync) accept a CancellationToken that the test runner can use
to cancel a long-running suite. Forwarding TestContext.Current.
CancellationToken to every call lets the runner respond to Ctrl+C /
--blame-hang-timeout at the granularity of a single test instead of
the whole process.

Covers PublishEndpointTests (10 calls), CircleMembersApiTests
(11 calls) and BlogApiMappedClaimsTests (9 calls). BlogApiTests.cs
was already clean after 422e8b76.
2026-08-22 03:45:59 +01:00
b679707b83 using clauses cleanup 2026-08-22 03:34:48 +01:00
422e8b766b refacto TestContext.Current.CancellationToken 2026-08-22 03:00:25 +01:00
e9d39eb84b Merge branch 'release/1.0.8-rc1' into feat/ui-testing 2026-08-22 02:42:08 +01:00
60731d7192 changelog: align 1.0.8-rc1 section title with release workflow
Some checks failed
Forgejo Release / release (push) Failing after 2m8s
1.0.8-rc1
The Forgejo release workflow validates the section title against the
channel derived from tag parity: '[TAG] - stable', '[TAG] - preview',
or '[TAG] - unstable'. The 2026-08-21 entry broke the validation with
'## [1.0.8-rc1] - 2026-08-21' (date suffix instead of channel). Move
the date into the body of the section (it is already mentioned in the
'Fixed' subsection) and use '## [1.0.8-rc1] - unstable' to match the
1.0.6 / 1.0.7 convention.
2026-08-21 23:07:34 +01:00
1306d6d59b release unstables 2026-08-21 22:51:25 +01:00
903d56ba98 changelog: section for 1.0.8-rc1
Ajoute la section [1.0.8-rc1] au CHANGELOG.md, en français, au format
Keep a Changelog (### Added / ### Changed / ### Fixed). Couvre :
- le fix backend du 500 sur POST /api/v1/blogacl (commit 83ad9cc1)
- le fix client PostIt (commit f557630a)
- le passage de CheckOwner en async (commit bdc87ccf)
- le seed one-shot de la fixture BlogsWebServerFixture
- les tests de non-régression (sentinelles 'never 500' et 'shape PostIt')
- la règle 'Pas de object' dans CONTRIBUTING.md

Met aussi à jour le bloc de liens de comparaison en bas du fichier
pour pointer [1.0.8-rc1] vers 1.0.7...1.0.8-rc1.
2026-08-21 22:43:31 +01:00
3aecca0936 Merge pull request 'feat/postit-acl-members' (#41) from feat/postit-acl-members into release/1.0.8-rc1
Reviewed-on: #41
2026-08-21 22:31:58 +01:00
83ad9cc111 acl post: reject BlogPostId <= 0 with 400, no 500
The 2026-08-21 prod 500 on POST /api/v1/blogacl was caused by the
PostIt client sending { circleId } only — the server deserialised
into CircleAuthorizationToBlogPost with BlogPostId = default(long) = 0,
and EF Core refused the INSERT with InvalidOperationException.

The PostIt-side fix lives in f557630a (enrich the payload with
blogPostId). This commit is the server-side guard: validate
BlogPostId > 0 in the controller and return 400 BadRequest instead
of letting the request reach SaveChangesAsync. The same shape that
crashed on 2026-08-21 now fails fast at the validation layer.

Verified by BlogAclApiTests.PostCircleAuthorization_dosent_return_500:
sentinel that asserts 'never 500' on a payload with BlogPostId = -1.
Previously red (500 from EF Core), now green (400 from the new guard).
2026-08-21 22:08:05 +01:00
bdc87ccf7d acl post: never 500 regression sentinel + async CheckOwner + fixture seed
The hard rule on POST /api/v1/blogacl is: a 500 is never acceptable,
regardless of the payload shape. The prod 500 logged on 2026-08-21 on
mercure was caused by the PostIt client sending { circleId } only, which
the server deserialised into CircleAuthorizationToBlogPost with
BlogPostId = default(long) = 0; EF Core refused the INSERT with
InvalidOperationException: The value of
'CircleAuthorizationToBlogPost.BlogPostId' is unknown. The PostIt fix
lives in f557630a (enrich the payload with blogPostId). The server-side
guard lives in this commit:

- BlogAclApiController.CheckOwner is now async and uses FirstOrDefaultAsync
  instead of First, so it does not deadlock the request thread and
  returns false on a missing circle (which the controller already maps
  to ChallengeResult).
- BlogsWebServerFixture now seeds Alice, her Circle and her BlogPost
  in ConfigurePipelineAsync, once at host startup, against the shared
  SqliteConnection (Cache=Shared). EnsureCreated is idempotent and
  runs against the connection that every DbContext resolves through,
  so the test theory can POST payloads with real FK ids against a
  schema that actually has the Circle / BlogSpot tables.
- BlogAclApiTests:
    - PostCircleAuthorization_returns_201_when_payload_mirrors_PostIt_shape
      is the regression sentinel for the prod fix.
    - PostCircleAuthorization_never_returns_500 is a [Theory] over
      several payload shapes; any future commit that reintroduces a
      500 path turns it red. CleanupAcl at the start of each insert-
      bearing test isolates against xUnit's no-guarantee-of-order
      execution: a successful POST in test N would otherwise conflict
      with test N+1 against the same (CircleId, BlogPostId) pair.
2026-08-21 22:00:27 +01:00
a74def4738 refacto seed test db 2026-08-21 20:45:46 +01:00