code guidelines

src/Yavsc/Controllers/Contracting/CoWorkingController.cs

@@ -11,7 +11,7 @@ namespace Yavsc.Controllers
 {
     public class CoWorkingController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public CoWorkingController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/CommandController.cs

@@ -90,7 +90,7 @@ namespace Yavsc.Controllers
         /// <param name="id"></param>
         /// <returns></returns>
         [HttpGet]
-        public IActionResult Create(string proId, string activityCode, string billingCode)
+        public IActionResult Create(string proId, string activityCode)
         {
             if (string.IsNullOrWhiteSpace(proId))
                 throw new InvalidOperationException(
@@ -159,7 +159,7 @@ namespace Yavsc.Controllers
                 _context.RdvQueries.Add(command, GraphBehavior.IncludeDependents);
                 _context.SaveChanges(User.GetUserId());
 
-                var yaev = command.CreateEvent(_localizer, "NewCommand");
+                var yaev = command.CreateEvent("NewCommand");
 
                 MessageWithPayloadResponse nrep = null;
 

src/Yavsc/Controllers/Contracting/CommandFormsController.cs

@@ -11,7 +11,7 @@ namespace Yavsc.Controllers
 {
     public class CommandFormsController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public CommandFormsController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/DjSettingsController.cs

@@ -8,7 +8,7 @@ namespace Yavsc.Controllers
 {
     public class DjSettingsController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public DjSettingsController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/EstimateController.cs

@@ -21,10 +21,9 @@ namespace Yavsc.Controllers
     [Authorize]
     public class EstimateController : Controller
     {
-        private ApplicationDbContext _context;
-        private SiteSettings _site;
-
-        IAuthorizationService authorizationService;
+        private readonly ApplicationDbContext _context;
+        private readonly SiteSettings _site;
+        readonly IAuthorizationService authorizationService;
 
         public EstimateController(ApplicationDbContext context, IAuthorizationService authorizationService, IOptions<SiteSettings> siteSettings)
         {
@@ -143,10 +142,6 @@ namespace Yavsc.Controllers
         }
 
 
-        private void Save(ICollection<IFormFile> newGraphics,
-         ICollection<IFormFile> newFiles) {
-
-         }
         // GET: Estimate/Edit/5
         public IActionResult Edit(long? id)
         {

src/Yavsc/Controllers/Contracting/FormsController.cs

@@ -9,7 +9,7 @@ namespace Yavsc.Controllers
 {
     public class FormsController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public FormsController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/FrontOfficeController.cs

@@ -18,13 +18,11 @@ namespace Yavsc.Controllers
 
     public class FrontOfficeController : Controller
     {
-        ApplicationDbContext _context;
-        UserManager<ApplicationUser> _userManager;
-
-        ILogger _logger;
-
-        IStringLocalizer _SR;
-        private IBillingService _billing;
+        readonly ApplicationDbContext _context;
+        readonly UserManager<ApplicationUser> _userManager;
+        readonly ILogger _logger;
+        readonly IStringLocalizer _SR;
+        private readonly IBillingService _billing;
 
         public FrontOfficeController(ApplicationDbContext context,
             UserManager<ApplicationUser> userManager,

src/Yavsc/Controllers/Contracting/GeneralSettingsController.cs

@@ -8,7 +8,7 @@ namespace Yavsc.Controllers
 {
     public class GeneralSettingsController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public GeneralSettingsController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/MusicalTendenciesController.cs

@@ -8,7 +8,7 @@ namespace Yavsc.Controllers
     using Models.Musical;
     public class MusicalTendenciesController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public MusicalTendenciesController(ApplicationDbContext context)
         {

src/Yavsc/Controllers/Contracting/SIRENExceptionsController.cs

@@ -10,7 +10,7 @@ namespace Yavsc.Controllers
     [Authorize(Roles="Administrator")]
     public class SIRENExceptionsController : Controller
     {
-        private ApplicationDbContext _context;
+        private readonly ApplicationDbContext _context;
 
         public SIRENExceptionsController(ApplicationDbContext context)
         {