notazof/yavsc
1
0
Fork 0
Code Issues Pull requests Projects 1 Releases 4 Packages Wiki Activity Actions

Revert "feat(blog): add Visibility { Private, Public } to gate post reads"

Browse source 
This reverts commit 33ecfa7ebd.
This commit is contained in:
Paul Schneider 2026-08-18 15:40:52 +01:00
commit 42625f5ddd
Signed by: notazof
GPG key ID: 1DD5D838E5343B06
16 changed files with 46 additions and 5427 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/Yavsc.Abstract/Blogspot/BlogPost.cs
View file

@ -19,18 +19,6 @@ public class BlogPostDto : IBlogPost
public string UserModified { get; set; }
public string Title { get; set; }
/// <summary>
/// Visibility of this post. Mirrors the EF entity
/// <c>Yavsc.Models.Blog.BlogPost.Visibility</c>: serialised
/// as an <c>int</c> by <c>System.Text.Json</c> (the enum's
/// underlying type), so clients see <c>0</c> or <c>1</c>
/// rather than <c>"Private"</c>/<c>"Public"</c>. Defaults
/// to <see cref="Visibility.Private"/> on construction, so
/// existing client code that doesn't set it explicitly
/// stays safe (private-by-default).
/// </summary>
public Visibility Visibility { get; set; } = Visibility.Private;
public bool AuthorizeCircle(long circleId)
{
throw new NotImplementedException();

41
src/Yavsc.Abstract/Blogspot/Visibility.cs
View file

@ -1,41 +0,0 @@
namespace Yavsc.Blogspot;
/// <summary>
/// Post visibility.
///
/// <list type="bullet">
/// <item><description>
/// <see cref="Public"/>: the post is read via its ACL. If the
/// ACL is empty, every caller sees the post (including
/// unauthenticated ones, on endpoints that allow it). If the
/// ACL is non-empty, only the author, the members of the
/// circles in the ACL, and administrators can read. Public +
/// non-empty ACL is therefore the "restrict by exception"
/// shape: open by default, narrowed by the ACL.
/// </description></item>
/// <item><description>
/// <see cref="Private"/>: the ACL is ignored at read time.
/// Only the author and administrators can read. The ACL list
/// is preserved in the database so that flipping the post
/// back to <see cref="Public"/> restores the previous
/// restriction without re-entry.
/// </description></item>
/// </list>
///
/// <para>The two values together form a two-axis model: the ACL
/// is the exception list (it can narrow Public), and Visibility
/// is the master switch (it can disable the ACL entirely when
/// set to Private).</para>
///
/// <para>Stored as <c>int</c> (not the enum name) — see the
/// <c>.HasConversion&lt;int&gt;()</c> on <c>BlogPost.Visibility</c>
/// in <c>Yavsc.Server.Models.ApplicationDbContext</c>. Keeping the
/// int mapping means queries stay cheap and the wire JSON is a
/// plain number; the trade-off is that reading the column by hand
/// requires knowing the enum ordering.</para>
/// </summary>
public enum Visibility
{
Private = 0,
Public = 1,
}