From 0965caaf4027e8eb8f01ed9aa67b91032d477867 Mon Sep 17 00:00:00 2001
From: Paul Schneider <paul@pschneider.fr>
Date: Tue, 30 Jun 2026 23:32:05 +0100
Subject: [PATCH] fixes and renaming

---
 .../Contracting/GeneralSettingsController.cs      | 14 +++++++-------
 src/Yavsc.Org/Views/Activity/Create.cshtml        | 14 +++++++-------
 src/Yavsc.Org/Views/Activity/Edit.cshtml          | 15 ++++++++-------
 src/Yavsc.Org/Views/GeneralSettings/Delete.cshtml |  4 ++--
 src/Yavsc.Org/Views/GeneralSettings/Edit.cshtml   |  2 +-
 src/Yavsc.Org/Views/GeneralSettings/Index.cshtml  |  4 ++--
 src/Yavsc.Server/Models/ApplicationDbContext.cs   |  2 +-
 .../{GeneralSettings.cs => MusicLoverSettings.cs} |  2 +-
 8 files changed, 29 insertions(+), 28 deletions(-)
 rename src/Yavsc.Server/Models/Musical/Profiles/{GeneralSettings.cs => MusicLoverSettings.cs} (84%)

diff --git a/src/Yavsc.Org/Controllers/Contracting/GeneralSettingsController.cs b/src/Yavsc.Org/Controllers/Contracting/GeneralSettingsController.cs
index 446cda01..1678f2a7 100644
--- a/src/Yavsc.Org/Controllers/Contracting/GeneralSettingsController.cs
+++ b/src/Yavsc.Org/Controllers/Contracting/GeneralSettingsController.cs
@@ -11,7 +11,7 @@ namespace Yavsc.Controllers
 
         public GeneralSettingsController(ApplicationDbContext context)
         {
-            _context = context;    
+            _context = context;
         }
 
         // GET: GeneralSettings
@@ -28,7 +28,7 @@ namespace Yavsc.Controllers
                 return NotFound();
             }
 
-            GeneralSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
+            MusicLoverSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
             if (generalSettings == null)
             {
                 return NotFound();
@@ -46,7 +46,7 @@ namespace Yavsc.Controllers
         // POST: GeneralSettings/Create
         [HttpPost]
         [ValidateAntiForgeryToken]
-        public async Task<IActionResult> Create(GeneralSettings generalSettings)
+        public async Task<IActionResult> Create(MusicLoverSettings generalSettings)
         {
             if (ModelState.IsValid)
             {
@@ -65,7 +65,7 @@ namespace Yavsc.Controllers
                 return NotFound();
             }
 
-            GeneralSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
+            MusicLoverSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
             if (generalSettings == null)
             {
                 return NotFound();
@@ -76,7 +76,7 @@ namespace Yavsc.Controllers
         // POST: GeneralSettings/Edit/5
         [HttpPost]
         [ValidateAntiForgeryToken]
-        public async Task<IActionResult> Edit(GeneralSettings generalSettings)
+        public async Task<IActionResult> Edit(MusicLoverSettings generalSettings)
         {
             if (ModelState.IsValid)
             {
@@ -96,7 +96,7 @@ namespace Yavsc.Controllers
                 return NotFound();
             }
 
-            GeneralSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
+            MusicLoverSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
             if (generalSettings == null)
             {
                 return NotFound();
@@ -110,7 +110,7 @@ namespace Yavsc.Controllers
         [ValidateAntiForgeryToken]
         public async Task<IActionResult> DeleteConfirmed(string id)
         {
-            GeneralSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
+            MusicLoverSettings generalSettings = await _context.GeneralSettings.SingleAsync(m => m.UserId == id);
             _context.GeneralSettings.Remove(generalSettings);
             await _context.SaveChangesAsync();
             return RedirectToAction("Index");
diff --git a/src/Yavsc.Org/Views/Activity/Create.cshtml b/src/Yavsc.Org/Views/Activity/Create.cshtml
index cc305557..0fe9938a 100644
--- a/src/Yavsc.Org/Views/Activity/Create.cshtml
+++ b/src/Yavsc.Org/Views/Activity/Create.cshtml
@@ -20,7 +20,7 @@
         </div>
         <div class="form-group">
             <label asp-for="Name" class="col-md-2 control-label">
-                Name"]</label>
+                Name</label>
             <div class="col-md-10">
                 <input asp-for="Name" class="form-control" />
                 <span asp-validation-for="Name" class="text-danger" ></span>
@@ -28,7 +28,7 @@
         </div>
         <div class="form-group">
             <label asp-for="Parent" class="col-md-2 control-label">
-                Parent"]</label>
+                Parent</label>
             <div class="col-md-10">
                 <select asp-for="ParentCode" asp-items=@ViewBag.ParentCode class="form-control" >
                 </select>
@@ -37,7 +37,7 @@
         </div>
         <div class="form-group">
             <label asp-for="Description" class="col-md-2 control-label">
-                Description"]</label>
+                Description</label>
             <div class="col-md-10">
                 <input asp-for="Description" class="form-control" />
                 <span asp-validation-for="Description" class="text-danger" ></span>
@@ -45,7 +45,7 @@
         </div>
         <div class="form-group">
             <label asp-for="Photo" class="col-md-2 control-label">
-                Photo"]
+                Photo
             </label>
             <div class="col-md-10">
                 <input asp-for="Photo" class="form-control" />
@@ -54,7 +54,7 @@
         </div>
         <div class="form-group">
             <label asp-for="SettingsClassName" class="col-md-2 control-label">
-                SettingsClass"]
+                SettingsClass
             </label>
             <div class="col-md-10">
                 <select asp-for="SettingsClassName" class="form-control" asp-items="@ViewBag.SettingsClassName">
@@ -62,12 +62,12 @@
                 <span asp-validation-for="SettingsClassName" class="text-danger" ></span>
             </div>
         </div>
-        
+
 
 
         <div class="form-group">
             <div class="col-md-offset-2 col-md-10">
-                <input type="submit" value="Create"]" class="btn btn-default" />
+                <input type="submit" value="Create" class="btn btn-default" />
             </div>
         </div>
     </div>
diff --git a/src/Yavsc.Org/Views/Activity/Edit.cshtml b/src/Yavsc.Org/Views/Activity/Edit.cshtml
index ea77d956..0f4e591a 100644
--- a/src/Yavsc.Org/Views/Activity/Edit.cshtml
+++ b/src/Yavsc.Org/Views/Activity/Edit.cshtml
@@ -19,7 +19,7 @@
                 <span asp-validation-for="Name" class="text-danger" ></span>
             </div>
         </div>
-        
+
         <div class="form-group">
             <label asp-for="Parent" class="col-md-2 control-label"></label>
             <div class="col-md-10">
@@ -54,13 +54,14 @@
                 <span asp-validation-for="SettingsClassName" class="text-danger" ></span>
             </div>
         </div>
-        <div class="form-group">
-            <label asp-for="Hidden" class="col-md-2 control-label"></label>
-            <div class="col-md-10">
-                <input asp-for="Hidden" class="form-control" />
-                <span asp-validation-for="Hidden" class="text-danger"></span>
-            </div>
+
+        <div class="form-check">
+          <input class="form-check-input" type="checkbox" asp-for="Hidden" id="Hidden">
+          <label class="form-check-label" for="Hidden">
+            Hidden activity
+          </label>
         </div>
+
         <div class="form-group">
             <label asp-for="Rate" class="col-md-2 control-label"></label>
             <div class="col-md-10">
diff --git a/src/Yavsc.Org/Views/GeneralSettings/Delete.cshtml b/src/Yavsc.Org/Views/GeneralSettings/Delete.cshtml
index 38c939c9..ee13adc8 100644
--- a/src/Yavsc.Org/Views/GeneralSettings/Delete.cshtml
+++ b/src/Yavsc.Org/Views/GeneralSettings/Delete.cshtml
@@ -1,4 +1,4 @@
-@model Yavsc.Models.Musical.Profiles.GeneralSettings
+@model Yavsc.Models.Musical.Profiles.MusicLoverSettings
 
 @{
     ViewBag.Title = "Delete";
@@ -12,7 +12,7 @@
     <hr />
     <dl class="dl-horizontal">
     </dl>
-    
+
     <form asp-action="Delete">
         <div class="form-actions no-color">
             <input type="submit" value="Delete" class="btn btn-primary" /> |
diff --git a/src/Yavsc.Org/Views/GeneralSettings/Edit.cshtml b/src/Yavsc.Org/Views/GeneralSettings/Edit.cshtml
index c70c1c07..4626b294 100644
--- a/src/Yavsc.Org/Views/GeneralSettings/Edit.cshtml
+++ b/src/Yavsc.Org/Views/GeneralSettings/Edit.cshtml
@@ -1,4 +1,4 @@
-@model Yavsc.Models.Musical.Profiles.GeneralSettings
+@model Yavsc.Models.Musical.Profiles.MusicLoverSettings
 
 @{
     ViewBag.Title = "Edit";
diff --git a/src/Yavsc.Org/Views/GeneralSettings/Index.cshtml b/src/Yavsc.Org/Views/GeneralSettings/Index.cshtml
index 28e8164a..1c950594 100644
--- a/src/Yavsc.Org/Views/GeneralSettings/Index.cshtml
+++ b/src/Yavsc.Org/Views/GeneralSettings/Index.cshtml
@@ -1,4 +1,4 @@
-@model Yavsc.Models.Musical.Profiles.GeneralSettings
+@model Yavsc.Models.Musical.Profiles.MusicLoverSettings
 
 @{
     ViewBag.Title = "Details";
@@ -19,7 +19,7 @@
     else {
     <p>
         Aucun profile renseigné"]
-        <a asp-action="Create" class="btn btn-success">Renseigner ce paramêtrage"]</a> 
+        <a asp-action="Create" class="btn btn-success">Renseigner ce paramêtrage"]</a>
     </p>
     }
 </div>
diff --git a/src/Yavsc.Server/Models/ApplicationDbContext.cs b/src/Yavsc.Server/Models/ApplicationDbContext.cs
index 1fedde82..0675fb6a 100644
--- a/src/Yavsc.Server/Models/ApplicationDbContext.cs
+++ b/src/Yavsc.Server/Models/ApplicationDbContext.cs
@@ -279,7 +279,7 @@ namespace Yavsc.Models
         public DbSet<FormationSettings> FormationSettings { get; set; }
 
         [ActivitySettings]
-        public DbSet<GeneralSettings> GeneralSettings { get; set; }
+        public DbSet<MusicLoverSettings> GeneralSettings { get; set; }
         public DbSet<CoWorking> CoWorking { get; set; }
 
         private void AddTimestamps(string userId)
diff --git a/src/Yavsc.Server/Models/Musical/Profiles/GeneralSettings.cs b/src/Yavsc.Server/Models/Musical/Profiles/MusicLoverSettings.cs
similarity index 84%
rename from src/Yavsc.Server/Models/Musical/Profiles/GeneralSettings.cs
rename to src/Yavsc.Server/Models/Musical/Profiles/MusicLoverSettings.cs
index 85400812..fae39a40 100644
--- a/src/Yavsc.Server/Models/Musical/Profiles/GeneralSettings.cs
+++ b/src/Yavsc.Server/Models/Musical/Profiles/MusicLoverSettings.cs
@@ -3,7 +3,7 @@ using System.ComponentModel.DataAnnotations;
 
 namespace Yavsc.Models.Musical.Profiles
 {
-    public class GeneralSettings : IUserSettings
+    public class MusicLoverSettings : IUserSettings
     {
         public virtual List<MusicalPreference> SoundColor { get; set; }
         [Key]